Skip to content

Include a conformance test for timestamps without colon in time zone. #21747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
May 15, 2025
Merged

Include a conformance test for timestamps without colon in time zone. #21747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions conformance/binary_json_conformance_suite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3258,6 +3258,9 @@ void BinaryAndJsonConformanceSuiteImpl<
R"({"optionalTimestamp": "0001-01-01T00:00:00z"})");
ExpectParseFailureForJson("TimestampJsonInputLowercaseT", REQUIRED,
R"({"optionalTimestamp": "0001-01-01t00:00:00Z"})");
ExpectParseFailureForJson(
"TimestampWithMissingColonInOffset", REQUIRED,
R"({"optionalTimestamp": "1970-01-01T08:00:01+0800"})");
ExpectSerializeFailureForJson("TimestampProtoInputTooSmall", REQUIRED,
"optional_timestamp: {seconds: -62135596801}");
ExpectSerializeFailureForJson("TimestampProtoInputTooLarge", REQUIRED,
Expand Down
1 change: 1 addition & 0 deletions conformance/failure_list_php.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ Required.*.ProtobufInput.ValidDataRepeated.FLOAT.UnpackedInput.JsonOutput
Required.*.ProtobufInput.ValidDataScalar.FLOAT[2].JsonOutput
Required.*.JsonInput.Int32FieldQuotedExponentialValue.* # Failed to parse input or produce output.
Required.*.JsonInput.AnyWithNoType.*
Required.*.JsonInput.TimestampWithMissingColonInOffset # Should have failed to parse, but didn't.
Loading