Skip to content

Conversation

alexeagle
Copy link
Collaborator

Includes pre-built protoc integrity hashes in the release artifact, in a new file bazel/private/prebuilt_tool_integrity.bzl

tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10

Next steps:

  • create toolchain definitions that fetch the prebuilt protoc from github releases
  • change logic in Bazel setup to use the prebuilt toolchain when desired
  • create a token from @protobuf-team-bot account and add to GHA secrets so the pull request to BCR opens

Includes pre-built protoc integrity hashes in the release artifact

tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10
@googleberg googleberg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 3, 2025
@mkruskal-google mkruskal-google self-requested a review October 8, 2025 18:10
@alexeagle
Copy link
Collaborator Author

Note @mkruskal-google I just did a fresh test from HEAD on my fork: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.11

good to merge, then I'll start on the next bit

@zhangskz
Copy link
Member

zhangskz commented Oct 9, 2025

IIUC, we should also be able to remove the Publish to BCR github apps and its configured repo access once we switch to using this workflow for publication to BCR right?

@copybara-service copybara-service bot closed this in 7051cc1 Oct 9, 2025
@alexeagle
Copy link
Collaborator Author

@zhangskz yes - now that this is merged, let's do those release prep steps? Remove the Publish to BCR app, instead we need to create a token from @protobuf-team-bot account and add to GHA secrets to open the pull request to BCR

zhangskz pushed a commit that referenced this pull request Oct 10, 2025
Includes pre-built protoc integrity hashes in the release artifact, in a new file `bazel/private/prebuilt_tool_integrity.bzl`

tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10

Next steps:
- create toolchain definitions that fetch the prebuilt protoc from github releases
- change logic in Bazel setup to use the prebuilt toolchain when desired
- create a token from @protobuf-team-bot account and add to GHA secrets so the pull request to BCR opens

Closes #23465

COPYBARA_INTEGRATE_REVIEW=#23465 from protocolbuffers:alexeagle/bazel-protoc-prebuilt 05314db
PiperOrigin-RevId: 817227717
zhangskz added a commit that referenced this pull request Oct 10, 2025
Includes pre-built protoc integrity hashes in the release artifact, in a new file `bazel/private/prebuilt_tool_integrity.bzl`

tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10

Next steps:
- create toolchain definitions that fetch the prebuilt protoc from github releases
- change logic in Bazel setup to use the prebuilt toolchain when desired
- create a token from @protobuf-team-bot account and add to GHA secrets so the pull request to BCR opens

Closes #23465

COPYBARA_INTEGRATE_REVIEW=#23465 from protocolbuffers:alexeagle/bazel-protoc-prebuilt 05314db
PiperOrigin-RevId: 817227717

Co-authored-by: Alex Eagle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🅰️ safe for tests Mark a commit as safe to run presubmits over

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants