-
Notifications
You must be signed in to change notification settings - Fork 15.9k
feat: update bazel central registry publish workflow #23465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Includes pre-built protoc integrity hashes in the release artifact tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10
Note @mkruskal-google I just did a fresh test from HEAD on my fork: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.11 good to merge, then I'll start on the next bit |
IIUC, we should also be able to remove the |
@zhangskz yes - now that this is merged, let's do those release prep steps? Remove the Publish to BCR app, instead we need to create a token from @protobuf-team-bot account and add to GHA secrets to open the pull request to BCR |
Includes pre-built protoc integrity hashes in the release artifact, in a new file `bazel/private/prebuilt_tool_integrity.bzl` tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10 Next steps: - create toolchain definitions that fetch the prebuilt protoc from github releases - change logic in Bazel setup to use the prebuilt toolchain when desired - create a token from @protobuf-team-bot account and add to GHA secrets so the pull request to BCR opens Closes #23465 COPYBARA_INTEGRATE_REVIEW=#23465 from protocolbuffers:alexeagle/bazel-protoc-prebuilt 05314db PiperOrigin-RevId: 817227717
Includes pre-built protoc integrity hashes in the release artifact, in a new file `bazel/private/prebuilt_tool_integrity.bzl` tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10 Next steps: - create toolchain definitions that fetch the prebuilt protoc from github releases - change logic in Bazel setup to use the prebuilt toolchain when desired - create a token from @protobuf-team-bot account and add to GHA secrets so the pull request to BCR opens Closes #23465 COPYBARA_INTEGRATE_REVIEW=#23465 from protocolbuffers:alexeagle/bazel-protoc-prebuilt 05314db PiperOrigin-RevId: 817227717 Co-authored-by: Alex Eagle <[email protected]>
Includes pre-built protoc integrity hashes in the release artifact, in a new file
bazel/private/prebuilt_tool_integrity.bzl
tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10
Next steps: