Add bzlmod support for system_python. #23621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_810716790
branch
3 times, most recently
from
8d67eb5 to
e067b9e
Compare
#test-continuous This creates a module extension for system python so that it can be used in bzlmod builds. The pip_parse setup (dynamically building a new repo) doesn't work in the new bzlmod model, so we use the regular pip extension pointed at system_python's interpreter. Remaining work to get off WORKSPACE: * The pip extension quickly fails in the case where there's no python available, unlike our system_python setup * Our windows upb tests were never actually running python, and system_python doesn't work (and breaks under bzlmod due to the above issue) * Some of the upb wheel tests still don't work on bzlmod yet because they depend on some very custom http_archive dependencies. Closes #18750 Closes #23313 Closes #23307 PiperOrigin-RevId: 810995270
copybara-service
bot
force-pushed
the
test_810716790
branch
from
e067b9e to
fa9ceb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bzlmod support for system_python.
#test-continuous
This creates a module extension for system python so that it can be used in bzlmod builds. The pip_parse setup (dynamically building a new repo) doesn't work in the new bzlmod model, so we use the regular pip extension pointed at system_python's interpreter.
Remaining work to get off WORKSPACE:
Closes #18750
Closes #23313
Closes #23307