Migrate windows upb tests to bzlmod. #23653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_811599776
branch
from
5468108 to
2001a12
Compare
This requires dropping the python tests, which were never actually being run due to system_python's silent failure mode on windows. These tests could actually be enabled with some fixes in rules_python PiperOrigin-RevId: 811863667
copybara-service
bot
force-pushed
the
test_811599776
branch
from
2001a12 to
b882eb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate windows upb tests to bzlmod.
This requires dropping the python tests, which were never actually being run due to system_python's silent failure mode on windows. These tests could actually be enabled with some fixes in rules_python