Fix import option handling when include_imports isn't set. #24092
+200
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_821854106
branch
from
0958c5f to
581b988
Compare
These should be handled like regular dependencies and not included in the output FileDescriptorSet. They're not useful on their own, and can be harmful by signaling files that aren't actually direct sources. Also allow descriptor set inputs with missing option dependencies. We won't *output* this, but we should honor it as an input since the option dependencies aren't really necessary. Notably, our kotlin blazel rules pass these stripped descriptor sets to protoc. PiperOrigin-RevId: 821854106
copybara-service
bot
force-pushed
the
test_821854106
branch
from
581b988 to
ef03c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix import option handling when include_imports isn't set.
These should be handled like regular dependencies and not included in the output FileDescriptorSet. They're not useful on their own, and can be harmful by signaling files that aren't actually direct sources.
Also allow descriptor set inputs with missing option dependencies. We won't output this, but we should honor it as an input since the option dependencies aren't really necessary. Notably, our kotlin blazel rules pass these stripped descriptor sets to protoc.