Mark rules_rust as a non-dev dependency #25521
Draft
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a critical step towards public rust_proto_library() support. We previously held this back due to concerns about bloat, but investigation has shown that rules_rust is set up sufficiently that the Rust toolchain will not be installed unless the user affirmatively uses rust_proto_library(), which makes the bloat concerns minimal. PiperOrigin-RevId: 861758625
copybara-service
bot
force-pushed
the
test_861758625
branch
from
026af57 to
1162dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark rules_rust as a non-dev dependency
This is a critical step towards public rust_proto_library() support.
We previously held this back due to concerns about bloat, but investigation has shown that rules_rust is set up sufficiently that the Rust toolchain will not be installed unless the user affirmatively uses rust_proto_library(), which makes the bloat concerns minimal.