Skip to content

fix: remove fs-extra#707

Merged
dbale-altoros merged 4 commits intoprotofire:developfrom
v1rtl:remove-fs-extra
Aug 15, 2025
Merged

fix: remove fs-extra#707
dbale-altoros merged 4 commits intoprotofire:developfrom
v1rtl:remove-fs-extra

Conversation

@v1rtl
Copy link
Contributor

@v1rtl v1rtl commented Aug 8, 2025

None of the extra utilities of fs-extra are used in solhint so it can be safely removed

@dbale-altoros
Copy link
Collaborator

hey @talentlessguy
as always , thanks for your input
as a general rule, i first approve the CI test... and if it is passed, I'll check the actual code
that being said, please fix the test so the CI gets completed... then i can check the code

thanks!

@v1rtl
Copy link
Contributor Author

v1rtl commented Aug 13, 2025

crap I missed the e2e tests, they still use fs-extra, will fix now

@dbale-altoros dbale-altoros merged commit 79bec8a into protofire:develop Aug 15, 2025
11 checks passed
@v1rtl v1rtl deleted the remove-fs-extra branch August 15, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants