Skip to content

fix: 🎨 getFormat not found #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025
Merged

Conversation

Jandelson
Copy link
Contributor

Add method to extract duration when video not has a property standard property duration. Example video webm where the duration exists in tags

Add method to extract duration when video not has a property standard property duration.  Example video webm where the duration exists in tags
@pascalbaljet
Copy link
Collaborator

Could you provide an example webm file? I've tried a webm video and it seems to work without your changes.

@Jandelson
Copy link
Contributor Author

Could you provide an example webm file? I've tried a webm video and it seems to work without your changes.
Hi @pascalbaljet
bellow video link to downloaded
Thaks!

https://app.box.com/s/n1e6jk1j03z8dl90kyvqvul044ukyd6y

@nagi1
Copy link

nagi1 commented Mar 25, 2025

This PR have a conflict:

in src/Drivers/InteractsWithMediaStreams.php

        if ($format->has('duration')) {
            return intval(round($format->get('duration') * 1000));
        }

I created a fork with all open PRs merged until @pascalbaljet or @protonemedia merge them.
https://github.com/nagi1/laravel-ffmpeg

Thanks For this awesome package really appreciated!

@pascalbaljet
Copy link
Collaborator

Thanks!

@pascalbaljet pascalbaljet merged commit 596804e into protonemedia:main Apr 1, 2025
0 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants