RSK feature merge #74
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes previous issues, especially with devnets of `Key Not Found in Database` error being emitted which happened, because of evm state snapshot reverts, or blockchain re-orgs
npm functionality to dev branch
- since rsk operates at 0 gas price, makes sense to allow it to be settable.
- improve amountToPay to take set gasprice into consideration, as depending on gasprice, the hardcoded value may have been too low or too high for certain networks.
fix(log-manager): remove call to non-existent fxn
chore(README): <- add rsk-specific flag to that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving here for now to help in comparing difference between it and master, and following testing to consider merge into master if there's nothing that would hurt the integrations of other EVM chains.