feat: initial implementation #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gskapka
requested changes
Nov 9, 2022
There was a problem hiding this comment.
The tests are good so far but the agreement contract's token balance needs to be asserted as well wherever where you've asserted claimant's token balances.
Otherwise, see inline comments re the contract itself. Some things should definitely be changed, others are suggestions and other probably need further discussion.
Let me know if I've misunderstood anything too please!
gskapka
approved these changes
Nov 9, 2022
…ptAndClaimOwner behavior
…ltering on rows with amount = 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title ...