Update DeclKind in z3-sys for new values#337
Open
twizmwazin wants to merge 4 commits intoprove-rs:masterfrom
Open
Update DeclKind in z3-sys for new values#337twizmwazin wants to merge 4 commits intoprove-rs:masterfrom
twizmwazin wants to merge 4 commits intoprove-rs:masterfrom
Conversation
Contributor
Author
|
I believe the ubuntu CI failure is due to Ubuntu 24.04 packaging z3 4.8.12, released in 2021, before some of these DeclKinds were added... I would advocate for bumping the minimum to something more recent. I don't know if that is palatable or conflicts with other goals though. |
Member
|
I ran into this same z3 issue on a project of mine. In my case, I re-targeted my docker setup on debian |
Contributor
Author
|
In my case I will be statically linking z3, so I'm basically always using the bundled option. |
toolCHAINZ
added
the
blocked: apt z3
Member
|
I think we'll pull the trigger on this in April when the next LTS updates their ancient apt z3 package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds all of the existing DeclKinds defined in the C API to the DeclKind enum. I did not add comments as they seemed inconsistent in the original. Let me know if I can improve this, I intend to add higher level bindings to various ops here for my use case.
Future work: This feels like it should be done as a macro.