feat: algebraic numbers, polynomials, enhanced floats, AST vectors, and quantifier elimination#500
Merged
toolCHAINZ merged 25 commits intomasterfrom Feb 24, 2026
Merged
feat: algebraic numbers, polynomials, enhanced floats, AST vectors, and quantifier elimination#500toolCHAINZ merged 25 commits intomasterfrom
toolCHAINZ merged 25 commits intomasterfrom
Conversation
…d floats, AST vectors, and quantifier elimination
Member
Author
|
As a reminder to myself, this PR makes actual high-level bindings around Z3_ast_vector. Previously we did not have these and there's lots of finnicky low-level construction of ast_vectors in the high-level bindings. An actual high-level binding for that type itself would probably allow for simplifying the implementation of many different APIs. |
simplification of internal ast_vector usage
Introduced Algebraic as a subtype of Real with arithmetic methods, comparison functions, and conversions from/to Real using TryFrom/From. Updated impl_ast macro to include Algebraic.
- Rename quantifier_elimination_simple to quantifier_elimination with improved API - Simplify and consolidate quantifier elimination methods - Remove deprecated variants and redundant code - Update exports and add new test module
- Update methods to use FuncDecl where appropriate - Return SatResult enum instead of raw lbool - Add relation registration method - Implement Display and Debug for Fixedpoint - Fix handling of symbols and CString usage - Add test for Horn clause solving with Fixedpoint
Member
Author
|
I am now fairly happy with these changes. The ubuntu CI failure I'm guessing is a very old upstream Z3 bug as it doesn't manifest in any other run and that one is using Z3 4.8. |
toolCHAINZ
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API extensions contributed by @NikolajBjorner using copilot.