Add make install-firmware command #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Makefile target, install-firmware, to allow users to install board firmware from a remote source. In addition, it fixes a minor typo in the sync-time target's description.
- Corrected the description for sync-time.
- Added a new install-firmware target and command.
| @@ -54,6 +54,11 @@ else | |||
| $(call rsync_to_dest,artifacts/proves,$(BOARD_MOUNT_POINT)) | |||
| endif | |||
|
|
|||
| # install-firmware | |||
| .PHONY: install-firmware | |||
| install-firmware: uv ## Install the board firmware onto a connected PROVES Kit | |||
There was a problem hiding this comment.
Consider documenting the significance of the 'v4' argument to enhance maintainability by clarifying its purpose.
Suggested change
| install-firmware: uv ## Install the board firmware onto a connected PROVES Kit | |
| install-firmware: uv ## Install the board firmware onto a connected PROVES Kit | |
| # The 'v4' argument specifies the firmware version to be installed. Update this if a new version is required. |
Copilot uses AI. Check for mistakes.
Mikefly123
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes proveskit/pysquared#241
Summary
This adds the
make install-firmwarecommand to the Makefile, which pulls theinstall_firmwarescript from https://github.com/proveskit/install-firmware. Tested that it works on macOS & Windows, but Linux still needs to be testedHow was this tested
Screen.Recording.2025-05-08.at.16.04.19-1.mov