-
Notifications
You must be signed in to change notification settings - Fork 1
Update repl Functionality #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR copies the full boot sequence from main.py
into repl.py
to provide REPL access for manual hardware testing, and updates the README to clarify usage and target boards.
- Added full initialization and boot logic to
repl.py
to mirror v5a behavior. - Updated imports and component setup in
repl.py
. - Refined README description and usage instructions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
repl.py | Inlined boot sequence, added hardware initialization, and set up REPL context. |
README.md | Clarified reference software usage and target boards; minor grammar updates. |
Comments suppressed due to low confidence (1)
repl.py:90
- [nitpick] The variable name
f
is ambiguous. Rename it to something more descriptive likefuncs
orcommand_functions
.
f = functions.functions(
Co-authored-by: Copilot <[email protected]>
Hey @DavidUniack if you happen to still have a V4x board on hand you could try this out with it would be quite appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my board and this works good, would just remove the block I highlighted
Removed unnecessary initial boot sequence Co-authored-by: aychar <[email protected]>
554efc7
to
7aaace1
Compare
Summary
This is a pretty straight forward PR. To mirror the way the v5a repo is current setup, I propose that we take the entire boot sequence from
main.py
and just copy / paste it intorepl.py
. This is a not a particularly elegant solution to giving functionality to theREPL
, but it does provide us with a stop gap for allowing people new to the Flight Controller Boards to run some manual tests on hardware to build out some knowledge of how things work!How was this tested
I don't have a board at home with me to test this today, but these changes worked when ran in the lab yesterday. I can verify again when I go in tomorrow.