Skip to content

Update repl Functionality #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025
Merged

Update repl Functionality #20

merged 5 commits into from
Jun 6, 2025

Conversation

Mikefly123
Copy link
Member

@Mikefly123 Mikefly123 commented May 21, 2025

Summary

This is a pretty straight forward PR. To mirror the way the v5a repo is current setup, I propose that we take the entire boot sequence from main.py and just copy / paste it into repl.py. This is a not a particularly elegant solution to giving functionality to the REPL, but it does provide us with a stop gap for allowing people new to the Flight Controller Boards to run some manual tests on hardware to build out some knowledge of how things work!

How was this tested

  • Added new unit tests
  • Ran code on hardware (screenshots are helpful)
  • Other (Please describe)

I don't have a board at home with me to test this today, but these changes worked when ran in the lab yesterday. I can verify again when I go in tomorrow.

@Mikefly123 Mikefly123 self-assigned this May 21, 2025
@Mikefly123 Mikefly123 added the enhancement New feature or request label May 21, 2025
@Mikefly123 Mikefly123 requested review from Copilot and a team May 21, 2025 21:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR copies the full boot sequence from main.py into repl.py to provide REPL access for manual hardware testing, and updates the README to clarify usage and target boards.

  • Added full initialization and boot logic to repl.py to mirror v5a behavior.
  • Updated imports and component setup in repl.py.
  • Refined README description and usage instructions.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
repl.py Inlined boot sequence, added hardware initialization, and set up REPL context.
README.md Clarified reference software usage and target boards; minor grammar updates.
Comments suppressed due to low confidence (1)

repl.py:90

  • [nitpick] The variable name f is ambiguous. Rename it to something more descriptive like funcs or command_functions.
f = functions.functions(

@Mikefly123 Mikefly123 requested a review from DavidUniack May 24, 2025 17:52
@Mikefly123
Copy link
Member Author

Hey @DavidUniack if you happen to still have a V4x board on hand you could try this out with it would be quite appreciated!

@hrfarmer hrfarmer self-requested a review May 24, 2025 18:10
Copy link
Member

@hrfarmer hrfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my board and this works good, would just remove the block I highlighted

Mikefly123 and others added 2 commits June 4, 2025 11:30
Removed unnecessary initial boot sequence

Co-authored-by: aychar <[email protected]>
@Mikefly123 Mikefly123 force-pushed the update-repl-functionality branch from 554efc7 to 7aaace1 Compare June 4, 2025 09:34
@Mikefly123 Mikefly123 requested a review from hrfarmer June 4, 2025 09:35
@hrfarmer hrfarmer merged commit 4fc060f into main Jun 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants