Skip to content

removing extra argument (version) and flipping the logger and config arguments in Satellite object construction in the REPL #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

blakejameson
Copy link
Contributor

Summary

As the new satellite constructor only takes in config and logger parameters, this was causing an error in the REPL.
I also realized that the logger and config arguments were flipped, so I fixed that

How was this tested

  • Added new unit tests
  • Ran code on hardware (screenshots are helpful)
  • Other (Please describe)

…paramaters to match the Satellite constructor
@blakejameson blakejameson requested review from Mikefly123 and a team April 9, 2025 23:04
Copy link
Member

@Mikefly123 Mikefly123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it!

@blakejameson blakejameson merged commit 947aa6d into main Apr 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants