refactor(ui): standardize "Providers" wording across UI and docs by pfe-nazaries · Pull Request #10971 · prowler-cloud/prowler

pfe-nazaries · 2026-05-04T09:29:00Z

Context

The Prowler UI used three different names for the same concept — "Cloud Providers", "Accounts", "Account Groups" — while the SDK, API, and Django models all use Provider / Provider Group. This PR aligns the UI and developer docs with the rest of the platform.

Description

UI strings — sidebar (menu-list.ts), /providers page (title, tabs, columns), wizard (provider-wizard-modal*, wizard-stepper.tsx), empty states (no-providers-{added,connected}.tsx), manage-groups (button + row actions + error), cross-page column headers and filters (Scans, Resources, Findings, data-filters.ts), and RBAC labels (lib/helper.ts, lib/permissions.ts):

Cloud Providers → Providers
Accounts / Account Groups → Providers / Provider Groups
Cloud Provider (column / wizard / filter) → Provider
Manage Cloud Providers → Manage Providers; Manage Account → Manage Provider

Internal contract — provider-page-tabs.shared.ts and all callers:

PROVIDER_TAB.ACCOUNTS / ACCOUNT_GROUPS → PROVIDERS / PROVIDER_GROUPS
URL slug: ?tab=accounts → ?tab=providers, ?tab=account-groups → ?tab=provider-groups (deep-link break)

Tests — vitest fixtures (provider-page-tabs.test.tsx, provider-wizard-modal.utils.test.ts, providers/page.test.ts) and Playwright (tests/providers/providers-page.ts, tests/scans/scans-page.ts).

Docs — docs/getting-started/basic-usage/prowler-app.mdx, docs/user-guide/tutorials/prowler-app*.mdx, docs/user-guide/tutorials/prowler-cloud-aws-organizations.mdx, all 16 docs/user-guide/providers/*/getting-started-*.mdx, docs/developer-guide/provider.mdx.

Preserved: brand titles ("Google Cloud Provider", "Alibaba Cloud Provider"), AWS Organizations terms ("Account ID", "Management Account", "AWS Cloud Account"), GCP "Service Account", and PNG filenames under docs/images/.

Steps to review

cd ui && pnpm install && pnpm run typecheck && pnpm run lint:check && pnpm run test:run — expect 591 tests passing.
Smoke /providers: title, tabs, columns, URL slug on tab switch.
Open the wizard from any empty state; confirm the new copy.
Check Scans / Resources / Findings column header and filters.
Open the Roles editor and Profile; confirm RBAC labels.
Verify AWS Organizations and GCP forms still use their original "Account" / "Service Account" labels.

Screenshots / Video — UI

Responsive

Mobile (X < 640px):
Tablet (640px ≤ X < 1024px):
Desktop (X ≥ 1024px):

Checklist

Community Checklist

This feature/issue is listed in here or roadmap.prowler.com
Is it assigned to me

Are there new checks included in this PR? No
Review if the code is being covered by tests.
Review if code is being documented following https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
Review if backport is needed.
Review if is needed to change the Readme.md
Ensure new entries are added to CHANGELOG.md, if applicable.

UI

All issue/task requirements work as expected on the UI
Screenshots/Video - Mobile (X < 640px)
Screenshots/Video - Tablet (640px > X < 1024px)
Screenshots/Video - Desktop (X > 1024px)
Ensure new entries are added to ui/CHANGELOG.md

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mintlify · 2026-05-04T09:29:09Z

Preview deployment for your docs. Learn more about Mintlify Previews.

Project	Status	Preview	Updated (UTC)
prowler	🟢 Ready	View Preview	May 4, 2026, 9:30 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

github-actions · 2026-05-04T09:29:28Z

✅ Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

github-actions · 2026-05-04T09:29:35Z

✅ All necessary CHANGELOG.md files have been updated.

github-actions · 2026-05-04T09:34:25Z

🔒 Container Security Scan

Image: prowler-ui:0637296
Last scan: 2026-05-05 11:16:26 UTC

📊 Vulnerability Summary

Severity	Count
🔴 Critical	2
Total	2

2 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

Review the detailed scan results
Update affected packages to patched versions
Consider using a different base image if updates are unavailable

📋 Resources:

Download full report (see artifacts)
View in Security tab
Scanned with Trivy

Standardization is a behaviour-visible change, not a bug fix; ship it in the next minor instead of patching 1.25.1. Also fill in the actual PR number (#10971). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Alan-TheGentleman

The Playwright locator on the scans page filters by stale text. ui/tests/scans/scans-page.ts:23 matches 'Choose a cloud provider', but this PR renamed the placeholder to 'Choose a provider' in select-scan-provider.tsx (L55, L70). The combobox locator will no longer match and the scans E2E suite will fail at runtime. Please update the filter text to 'Choose a provider'. (Cannot anchor inline because line 23 is outside the diff hunk.)
The manage_account permission was relabeled to "Manage Provider". See the inline comment on ui/lib/helper.ts.

Other things that look incomplete relative to the stated scope ("UI strings ... and all callers"):

ui/app/(prowler)/providers/account-groups-content.tsx L60, L63, L130, L132 still render "Create a new account group" / "Edit account group" headings inside the Provider Groups tab.
The tabs component still exports accountsContent / accountGroupsContent props and page.tsx still references the AccountGroupsContent class, so the internal API does not match the new PROVIDER_TAB.PROVIDERS / PROVIDER_GROUPS enum.
ui/tests/setups/manage-cloud-providers.auth.setup.ts and several Playwright comments still carry the old wording.

Worth considering a temporary redirect from ?tab=accounts to ?tab=providers so existing bookmarks do not break silently after the slug change.

Replace legacy "Cloud Providers" / "Accounts" / "Account Groups" copy with the canonical "Provider" / "Provider Group" terms aligned with the SDK, API, and Django models. Also rename PROVIDER_TAB enum keys/values and URL slug (?tab=accounts → ?tab=providers, ?tab=account-groups → ?tab=provider-groups). Brand references ("Google Cloud Provider", "AlibabaCloud Provider") and genuine cloud-account constructs ("AWS account", "Service Account", "Account ID", "Management Account") are preserved per design D3. PROWLER-1468 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Original audit was case-sensitive and missed lowercase variants visible in the scan launch flow, empty states, overview filters, and the manage_providers permission description. Replace with 'provider' / 'providers' for consistency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Standardization is a behaviour-visible change, not a bug fix; ship it in the next minor instead of patching 1.25.1. Also fill in the actual PR number (#10971). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- Revert manage_account label rename: it is a distinct RBAC permission for org/tenant settings (users, billing, RBAC), not provider management. Keep 'Manage Account' in helper.ts and permissions.ts. - Fix stale Playwright locator in tests/scans/scans-page.ts:23 that still filtered the combobox by the old 'Choose a cloud provider' text. - Rename provider-page-tabs props (accountsContent/accountGroupsContent -> providersContent/providerGroupsContent), the AccountGroupsContent component (-> ProviderGroupsContent), and the matching file (account-groups-content.tsx -> provider-groups-content.tsx) to align the internal API with PROVIDER_TAB.PROVIDERS / PROVIDER_GROUPS. - Update Provider Groups tab headings and prose ('Create a new account group' / 'Edit account group' -> 'provider group'). - Update stale wording in tests/setups/manage-cloud-providers.auth.setup test description and Playwright comments in tests/providers/providers- page.ts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

jfagoagas

Thanks for this one!

# Conflicts: # ui/CHANGELOG.md

…can list Aligns the Attack Paths scan-list table with the canonical "Provider" wording used across Scans, Resources and Findings tables. The cell already renders provider data (provider_alias / provider_uid via EntityInfo), so the prior "Account" header was the last Provider-synonym column header in the UI. Captured by spec scenario "Cross-page table column header" and tasks §11.4 in the standardize-providers-wording openspec change.

pfe-nazaries · 2026-05-05T09:31:42Z

@Alan-TheGentleman @jfagoagas Small tweak e1a5e4d

PR #10939 collapsed the compliance card to an always-stacked column layout and removed `sm:flex-row`, but the existing source assertion test was not updated and started failing in CI on every PR that touched the UI. Update the assertion to reflect the new layout and rename the test case accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions Bot added documentation component/ui labels May 4, 2026

mintlify Bot deployed to staging - docs May 4, 2026 09:30 View deployment

pfe-nazaries marked this pull request as ready for review May 4, 2026 12:31

pfe-nazaries requested review from a team as code owners May 4, 2026 12:31

jfagoagas reviewed May 4, 2026

View reviewed changes

Comment thread ui/lib/helper.ts Outdated

Alan-TheGentleman requested changes May 4, 2026

View reviewed changes

Comment thread ui/lib/helper.ts Outdated

Pablo F.G and others added 4 commits May 4, 2026 16:45

pfe-nazaries force-pushed the fix/provider-wording branch from 219e68a to dce1ee6 Compare May 4, 2026 14:58

mintlify Bot deployed to staging - docs May 4, 2026 14:59 View deployment

pfe-nazaries requested review from Alan-TheGentleman and jfagoagas May 4, 2026 15:00

jfagoagas reviewed May 4, 2026

View reviewed changes

Comment thread docs/developer-guide/provider.mdx

jfagoagas previously approved these changes May 4, 2026

View reviewed changes

Pablo F.G added 2 commits May 5, 2026 08:51

Merge remote-tracking branch 'origin/master' into fix/provider-wording

51d8d65

# Conflicts: # ui/CHANGELOG.md

pfe-nazaries dismissed jfagoagas’s stale review via e1a5e4d May 5, 2026 08:02

mintlify Bot deployed to staging - docs May 5, 2026 08:03 View deployment

Merge remote-tracking branch 'origin/master' into fix/provider-wording

f45da4a

mintlify Bot deployed to staging - docs May 5, 2026 09:30 View deployment

jfagoagas previously approved these changes May 5, 2026

View reviewed changes

Alan-TheGentleman previously approved these changes May 5, 2026

View reviewed changes

pfe-nazaries dismissed stale reviews from Alan-TheGentleman and jfagoagas via dd6d08a May 5, 2026 11:09

jfagoagas approved these changes May 5, 2026

View reviewed changes

pfe-nazaries merged commit d23c2f3 into master May 5, 2026
39 checks passed

pfe-nazaries deleted the fix/provider-wording branch May 5, 2026 12:39

HugoPBrito mentioned this pull request May 11, 2026

fix(ui): label finding drawer column as Provider, not Account #11102

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(ui): standardize "Providers" wording across UI and docs#10971

refactor(ui): standardize "Providers" wording across UI and docs#10971
pfe-nazaries merged 8 commits into
masterfrom
fix/provider-wording

pfe-nazaries commented May 4, 2026 •

edited

Loading

Uh oh!

mintlify Bot commented May 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Alan-TheGentleman left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

jfagoagas left a comment

Uh oh!

pfe-nazaries commented May 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

pfe-nazaries commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Description

Steps to review

Screenshots / Video — UI

Responsive

Checklist

UI

License

Uh oh!

mintlify Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔒 Container Security Scan

📊 Vulnerability Summary

⚠️ Action Required

Uh oh!

Uh oh!

Alan-TheGentleman left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jfagoagas left a comment

Choose a reason for hiding this comment

Uh oh!

pfe-nazaries commented May 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pfe-nazaries commented May 4, 2026 •

edited

Loading

mintlify Bot commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading

Alan-TheGentleman left a comment •

edited

Loading