Skip to content

fix(attack-surface): restore ec2-imdsv1 category alignment#10998

Open
danibarranqueroo wants to merge 2 commits intomasterfrom
fix/restore-ec2-imdsv1-category-alignment
Open

fix(attack-surface): restore ec2-imdsv1 category alignment#10998
danibarranqueroo wants to merge 2 commits intomasterfrom
fix/restore-ec2-imdsv1-category-alignment

Conversation

@danibarranqueroo
Copy link
Copy Markdown
Member

Context

The EC2 with IMDSv1 enabled card in Attack Surface was redirecting to /findings with filter[category__in]=ec2-imdsv1, but that category was no longer present in the relevant finding metadata. As a result, the drill-down did not match the card behavior.

Description

This PR restores the ec2-imdsv1 category in the affected EC2 IMDS checks and re-aligns the attack-surface mapping with those checks. This keeps the existing UI behavior unchanged while making the Attack Surface card and the findings page filter consistent again.

Steps to review

Please add a detailed description of how to review this PR.

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? Yes / No
    • If so, do we need to update permissions for the provider? Please review this carefully.

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • All issue/task requirements work as expected on the API
  • Endpoint response output (if applicable)
  • EXPLAIN ANALYZE output for new/modified queries or indexes (if applicable)
  • Performance test results (if applicable)
  • Any other relevant evidence of the implementation (if applicable)
  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners May 5, 2026 09:00
@github-actions github-actions Bot added provider/aws Issues/PRs related with the AWS provider component/api metadata-review labels May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

  • api

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🔒 Container Security Scan

Image: prowler:c365d85
Last scan: 2026-05-05 09:14:23 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 5
Total 5

5 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

🔒 Container Security Scan

Image: prowler-api:c365d85
Last scan: 2026-05-05 09:18:15 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 10
Total 10

9 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.35%. Comparing base (7c6d658) to head (f8db572).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10998      +/-   ##
==========================================
+ Coverage   59.14%   65.35%   +6.20%     
==========================================
  Files           8     1080    +1072     
  Lines         399    58595   +58196     
==========================================
+ Hits          236    38295   +38059     
- Misses        163    20300   +20137     
Flag Coverage Δ
api 93.65% <100.00%> (?)
prowler-py3.10-aws 26.40% <ø> (?)
prowler-py3.10-kubernetes ?
prowler-py3.11-aws 26.39% <ø> (?)
prowler-py3.11-kubernetes ?
prowler-py3.12-aws 26.40% <ø> (?)
prowler-py3.12-kubernetes ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 26.40% <ø> (-32.75%) ⬇️
api 93.65% <100.00%> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danibarranqueroo
Copy link
Copy Markdown
Member Author

Now that category filter is working as expected
image

@danibarranqueroo danibarranqueroo added no-changelog Skip including change in changelog/release notes labels May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/api metadata-review no-changelog Skip including change in changelog/release notes provider/aws Issues/PRs related with the AWS provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant