[CHAIN] fix(ui): improve attack paths graph layout highlights#11017
Merged
Alan-TheGentleman merged 1 commit intoPROWLER-1273/react-flow-migrationfrom May 8, 2026
Conversation
12 tasks
Alan-TheGentleman
changed the title
12 tasks
pfe-nazaries
reviewed
May 8, 2026
| ), | ||
|
|
||
| http.get<{ findingId: string }>(`${API}/findings/:findingId`, ({ params }) => | ||
| HttpResponse.json(toFindingApiResponse(fx, params.findingId)), |
Contributor
There was a problem hiding this comment.
Type the response to have assistance from the compiler in case it changes and we dont update it here
pfe-nazaries
reviewed
May 8, 2026
|
|
||
| import { ResourceNode } from "./resource-node"; | ||
|
|
||
| const hiddenHandlesMock = vi.hoisted(() => vi.fn(() => null)); |
Contributor
There was a problem hiding this comment.
This mock should be cleared or remocked between each test
pfe-nazaries
reviewed
May 8, 2026
| await graph.executeQuery(); | ||
| await graph.waitForLayoutStable(3); | ||
|
|
||
| await graph.clickFirstResourceNodeWithoutFindings(); |
Contributor
There was a problem hiding this comment.
Add waitForTransistion call similar to the other test
pfe-nazaries
approved these changes
May 8, 2026
Alan-TheGentleman
force-pushed
the
PROWLER-1273/attack-path-node-icon-coverage
branch
from
c309218 to
bc212d5
Compare
Alan-TheGentleman
force-pushed
the
PROWLER-1273/attack-path-layout-highlights
branch
from
d8bd77c to
544b9e4
Compare
Alan-TheGentleman
force-pushed
the
PROWLER-1273/attack-path-node-icon-coverage
branch
from
bc212d5 to
bd8880b
Compare
Base automatically changed from
PROWLER-1273/attack-path-node-icon-coverage
to
PROWLER-1273/react-flow-migration
May 8, 2026 12:52
Alan-TheGentleman
force-pushed
the
PROWLER-1273/attack-path-layout-highlights
branch
from
544b9e4 to
a505e10
Compare
Alan-TheGentleman
merged commit 347e933
into
PROWLER-1273/react-flow-migration
3 checks passed
Alan-TheGentleman
added a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Part of Chained PRs
PROWLER-1273/react-flow-migrationChain Overview
Context
Part of the Attack Paths React Flow migration chain tracked by #10686. This slice builds on the node icon coverage work and focuses on graph layout direction, edge handles, and highlighted-path behavior.
Description
Changes:
Steps to review
Validated locally during implementation:
Checklist
Community Checklist
UI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.