Skip to content

feat(aws): rename Essential Eight to ASD Essential Eight#11054

Merged
pedrooot merged 2 commits into
masterfrom
rename-asd-essential-compliance
May 6, 2026
Merged

feat(aws): rename Essential Eight to ASD Essential Eight#11054
pedrooot merged 2 commits into
masterfrom
rename-asd-essential-compliance

Conversation

@pedrooot

@pedrooot pedrooot commented May 6, 2026

Copy link
Copy Markdown
Member

Description

This PR updates the Essential Eight compliance framework to ASD Essential Eight.

Steps to review

Please add a detailed description of how to review this PR.

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? Yes / No
    • If so, do we need to update permissions for the provider? Please review this carefully.

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • All issue/task requirements work as expected on the API
  • Endpoint response output (if applicable)
  • EXPLAIN ANALYZE output for new/modified queries or indexes (if applicable)
  • Performance test results (if applicable)
  • Any other relevant evidence of the implementation (if applicable)
  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners May 6, 2026 09:03
@github-actions github-actions Bot added the compliance Issues/PRs related with the Compliance Frameworks label May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

  • prowler

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@pedrooot pedrooot added the no-changelog Skip including change in changelog/release notes label May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🔒 Container Security Scan

Image: prowler:08d4cf0
Last scan: 2026-05-06 09:56:50 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 4
Total 4

4 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

pedrooot added a commit that referenced this pull request May 6, 2026
@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.18%. Comparing base (8affbf4) to head (65e3aae).
⚠️ Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8affbf4) and HEAD (65e3aae). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8affbf4) HEAD (65e3aae)
api 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11054      +/-   ##
==========================================
- Coverage   93.65%   85.18%   -8.48%     
==========================================
  Files         230      961     +731     
  Lines       33937    32652    -1285     
==========================================
- Hits        31784    27813    -3971     
- Misses       2153     4839    +2686     
Flag Coverage Δ
api ?
prowler-py3.10-aws 90.02% <ø> (?)
prowler-py3.10-lib 85.17% <64.00%> (?)
prowler-py3.11-aws 90.02% <ø> (?)
prowler-py3.11-lib 85.17% <64.00%> (?)
prowler-py3.12-aws 90.02% <ø> (?)
prowler-py3.12-lib 85.17% <64.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 85.18% <64.00%> (∅)
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pedrooot pedrooot merged commit e585ae4 into master May 6, 2026
22 of 24 checks passed
@pedrooot pedrooot deleted the rename-asd-essential-compliance branch May 6, 2026 11:11
b-abderrahmane added a commit to b-abderrahmane/prowler that referenced this pull request May 12, 2026
The previously-pinned prowler SDK commit (16798e2) predates the
`essential_eight` -> `asd_essential_eight` rename (prowler-cloud#11054) that
landed in the API import path on the recent merge from master, causing
api-tests to fail at collection with:

  ModuleNotFoundError: No module named
  'prowler.lib.outputs.compliance.asd_essential_eight'

Move the pinned commit to 759f7b8, which contains the renamed module
and matches the API code on this branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compliance Issues/PRs related with the Compliance Frameworks no-changelog Skip including change in changelog/release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants