revert(ci): drop workflow-level paths on required-check workflows#11055
Merged
cesararroba merged 1 commit intomasterfrom May 6, 2026
Merged
revert(ci): drop workflow-level paths on required-check workflows#11055cesararroba merged 1 commit intomasterfrom
cesararroba merged 1 commit intomasterfrom
Conversation
Contributor
|
✅ All necessary |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11055 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 230 230
Lines 33937 33937
=======================================
Hits 31784 31784
Misses 2153 2153
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR #11007 (commit
beea27aa0) added workflow-levelpaths:filters to 8 workflows. Five of them have job names that are enrolled as required-status-checks onmaster:sdk-tests (3.10/3.11/3.12),sdk-code-quality (3.10/3.11/3.12),ui-tests,api-tests (3.12),api-code-quality (3.12). Result: any PR that doesn't touch matching paths leaves those required checks pending forever, blocking the PR.Concrete victim today: PR #11049 (
chore(pyproject): revert API changes) has 7 pending required checks because it only touchesapi/pyproject.toml/api/poetry.lock.Same problem propagated to
prowler-cloudvia the workflow mirror, whereapi-tests (3.12)andapi-code-quality (3.12)are also required.Description
Removes the
paths:block frompush:andpull_request:triggers in 5 files. Each workflow's pre-existing internaltj-actions/changed-filesskip logic remains intact, so jobs short-circuit when their domain didn't change while still reporting the required check (assuccessorskipped).Files:
.github/workflows/sdk-tests.yml.github/workflows/sdk-code-quality.yml.github/workflows/ui-tests.yml.github/workflows/api-tests.yml.github/workflows/api-code-quality.ymlWorkflows whose checks are NOT required (
sdk-security,sdk-check-duplicate-test-names,api-security, four*-container-checks) keep their workflow-level paths — they continue to save minutes without breaking anything.Steps to review
paths:block is gone from bothpush:andpull_request:in each of the 5 files.branches:filter is intact on each trigger.tj-actions/changed-filesreferences are preserved (so jobs still short-circuit when their domain didn't change).Checklist
Community Checklist
SDK/CLI
sdk-tests,sdk-code-quality).UI
ui-tests).API
api-tests,api-code-quality).License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.