Skip to content

revert(ci): drop workflow-level paths on required-check workflows#11055

Merged
cesararroba merged 1 commit intomasterfrom
ci/revert-required-check-workflow-paths
May 6, 2026
Merged

revert(ci): drop workflow-level paths on required-check workflows#11055
cesararroba merged 1 commit intomasterfrom
ci/revert-required-check-workflow-paths

Conversation

@cesararroba
Copy link
Copy Markdown
Contributor

Context

PR #11007 (commit beea27aa0) added workflow-level paths: filters to 8 workflows. Five of them have job names that are enrolled as required-status-checks on master: sdk-tests (3.10/3.11/3.12), sdk-code-quality (3.10/3.11/3.12), ui-tests, api-tests (3.12), api-code-quality (3.12). Result: any PR that doesn't touch matching paths leaves those required checks pending forever, blocking the PR.

Concrete victim today: PR #11049 (chore(pyproject): revert API changes) has 7 pending required checks because it only touches api/pyproject.toml / api/poetry.lock.

Same problem propagated to prowler-cloud via the workflow mirror, where api-tests (3.12) and api-code-quality (3.12) are also required.

Description

Removes the paths: block from push: and pull_request: triggers in 5 files. Each workflow's pre-existing internal tj-actions/changed-files skip logic remains intact, so jobs short-circuit when their domain didn't change while still reporting the required check (as success or skipped).

Files:

  • .github/workflows/sdk-tests.yml
  • .github/workflows/sdk-code-quality.yml
  • .github/workflows/ui-tests.yml
  • .github/workflows/api-tests.yml
  • .github/workflows/api-code-quality.yml

Workflows whose checks are NOT required (sdk-security, sdk-check-duplicate-test-names, api-security, four *-container-checks) keep their workflow-level paths — they continue to save minutes without breaking anything.

Steps to review

  • Confirm the paths: block is gone from both push: and pull_request: in each of the 5 files.
  • Confirm branches: filter is intact on each trigger.
  • Confirm no other content changed in the affected files.
  • Confirm internal tj-actions/changed-files references are preserved (so jobs still short-circuit when their domain didn't change).

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Workflow change affects SDK/CLI required checks (sdk-tests, sdk-code-quality).
  • Are there new checks included in this PR? No

UI

  • Workflow change affects UI required check (ui-tests).
  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • Workflow change affects API required checks (api-tests, api-code-quality).
  • All issue/task requirements work as expected on the API
  • Endpoint response output (if applicable)
  • EXPLAIN ANALYZE output for new/modified queries or indexes (if applicable)
  • Performance test results (if applicable)
  • Any other relevant evidence of the implementation (if applicable)
  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cesararroba cesararroba requested a review from a team as a code owner May 6, 2026 09:48
@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@cesararroba cesararroba merged commit 8affbf4 into master May 6, 2026
20 checks passed
@cesararroba cesararroba deleted the ci/revert-required-check-workflow-paths branch May 6, 2026 09:49
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.65%. Comparing base (9827768) to head (ddd9947).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11055   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         230      230           
  Lines       33937    33937           
=======================================
  Hits        31784    31784           
  Misses       2153     2153           
Flag Coverage Δ
api 93.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler ∅ <ø> (∅)
api 93.65% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant