chore: remove pre-push from default install hook types#11072
Merged
Conversation
- Drop pre-push from default_install_hook_types so only pre-commit hooks run by default - Keep trufflehog declared with pre-push stage so it remains available when pre-push is installed - Collapse multi-line args/files mappings for readability
Contributor
|
✅ All necessary |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
- Document `prek install --hook-type pre-push` to enable TruffleHog secret scanning before push
jfagoagas
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Pre-push hooks were running every push, slowing down the developer workflow even for routine pushes. The only check we still want enforced before pushing is secret detection (
trufflehog); everything else (formatters, linters, security scanners) already runs atpre-committime.Description
pre-pushfromdefault_install_hook_typessoprek installonly registerspre-commithooks by default.trufflehogdeclared withstages: ["pre-commit", "pre-push"]so it remains available when developers opt in to thepre-pushhook type (prek install --hook-type pre-push).args/filesmappings onto single lines for readability.docs/developer-guide/introduction.mdxwith a new Enable TruffleHog as a Pre-Push Hook subsection documenting the opt-inprek install --hook-type pre-pushworkflow.No runtime behavior of Prowler changes — this only affects local developer tooling.
Steps to review
.pre-commit-config.yamlanddocs/developer-guide/introduction.mdx.pre-commitis installed:git pushno longer triggers the previous pre-push hook chain, and that with the opt-in installed, TruffleHog runs on push.docs/developer-guide/introduction.mdxand confirm the new subsection appears under Pre-Commit Hooks.Checklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.