feat(ui): improve dark mode contrast for editorial readability#11073
Open
HugoPBrito wants to merge 2 commits intoprowler-cloud:masterfrom
Open
feat(ui): improve dark mode contrast for editorial readability#11073HugoPBrito wants to merge 2 commits intoprowler-cloud:masterfrom
HugoPBrito wants to merge 2 commits intoprowler-cloud:masterfrom
Conversation
- Pure-black canvas (#000) and pure-white primary text - Brighter input and border tokens for clearer element separation - Sync HeroUI dark theme background and foreground with new tokens
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
pfe-nazaries
approved these changes
May 8, 2026
| --bg-input-primary: var(--color-neutral-900); | ||
| --border-input-primary: var(--color-neutral-800); | ||
| --border-input-primary-press: var(--color-neutral-800); | ||
| --bg-input-primary: #0a0a0a; |
Contributor
There was a problem hiding this comment.
If an equivalent (or really close) color exist in tailwind i would suggest to use that
pfe-nazaries
reviewed
May 8, 2026
| --bg-input-primary: var(--color-neutral-900); | ||
| --border-input-primary: var(--color-neutral-800); | ||
| --border-input-primary-press: var(--color-neutral-800); | ||
| --bg-input-primary: #0a0a0a; |
Contributor
There was a problem hiding this comment.
Also try this color and see if improve the contrast even more 111111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Dark mode on
masteruses near-black surfaces (zinc-950,stone-950) and dim borders (zinc-800/900) that flatten cards, tables, and inputs into the canvas. This PR tightens dark-theme contrast so elements read clearly without touching light mode, brand colours, or any component code.Description
Token-only changes scoped to
.darkinui/styles/globals.cssand the HeroUI dark theme inui/tailwind.config.js:#000000) with pure-white primary text (#ffffff)zinc-700/zinc-800) so cards, dividers, and table grids are visible on the new canvas#0a0a0a) framed by visiblezinc-700bordersred-400,orange-400) keeps error / warning states readable on#000backgroundsynced to#000000andforegroundto#ffffffso HeroUI components match the CSS tokensLight mode and brand colours (mint primary, focus, pass / success greens) are untouched. Diff is 19 lines added, 15 modified across two files; no component, type, or behaviour changes.
Steps to review
cd ui && pnpm install && pnpm run devmasterChecklist
Community Checklist
UI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.