Optimize MMU behaviour#353
Merged
Merged
Conversation
|
All values in bytes. Δ Delta to base
|
Automated Test Code Coverage ReportView details...
TOTAL: 2719 lines of code, 2018 lines executed, 74% covered. |
gudnimg
reviewed
Nov 24, 2025
gudnimg
previously approved these changes
Nov 29, 2025
gudnimg
left a comment
gudnimg
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good to me. I don't spot any issues with the code. 👍
gudnimg
reviewed
Nov 30, 2025
added 5 commits
December 1, 2025 09:09
Beware: behaviour breaking change, from now on non-reworked MK4 and MK3 cannot work with the MMU because there is no way to turn off their fsensor and trigger the unload. Hence the version bump to 3.0.4 But, on MMU-reworked MK4 and C1 this saves 2s per toolchange
added 6 commits
December 1, 2025 09:11
In the entire code base, we basically use 4 LED scenarios: - all off - active slot green on - active slot green blinking - active slot red blinking Compacting this behaviour into 4 functions saves in total ~140B - which is huge. It's not an entirely clean solution, LEDs should not know anything about globals::ActiveSlot, but the savings are more important. Ideally, such an optimization could have been done by the compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a collection of improvements in order to make tool changing even faster.
Of course, a corresponding counterpart on the printer's side will be necessary - i.e. this will NOT work on MK3-row of machines, so do not even attempt to use it unless you are willing to backport the changes to the 8bit printer's FW.
Hence the increased version of the MMU FW to 3.0.4.
The key ideas:
Some optimizations added to save space: