Fix MMU3 fsensor handling#360
Open
Lapeno89 wants to merge 1 commit into
Open
Conversation
|
All values in bytes. Δ Delta to base
|
Automated Test Code Coverage ReportView details...
TOTAL: 2746 lines of code, 2023 lines executed, 73% covered. |
Collaborator
|
@Lapeno89 thanks for opening a PR. The PR in its current state is not ready for a merge.
The PR consumes 168 bytes of flash which is a lot when considering how much free flash memory is left. Not a blocker in and of itself, but before we can merge, it would be good to optimize the code as much as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed:
If the fsensor remains ON, the MMU3 attempts (up to two times) to retract 1 mm of filament.
If the fsensor turns OFF, the filament is fully unloaded.
If it stays ON, an fsensor failure is reported on the printer display.