Slicing.cpp: PrintObjectSlice.cpp: Allow switching printers with incompatible min/max layer height. #14350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… incompatible min/max layer height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a friendly warning instead of crashing when user changes printer to one with an unsupported minimum or maximum layer height setting. Thus allowing them to choose different layer height, turn off VLH, adjust printer settings, etc.
$ make test
Running tests...
Test project /home/k/Downloads/src/Prusa/build
Start 1: libseqarrange_tests
1/7 Test #1: libseqarrange_tests .............. Passed 53.59 sec
Start 2: arrange_tests
2/7 Test #2: arrange_tests .................... Passed 3.50 sec
Start 3: thumbnails_tests
3/7 Test #3: thumbnails_tests ................. Passed 0.01 sec
Start 4: libslic3r_tests
4/7 Test #4: libslic3r_tests .................. Passed 7.82 sec
Start 5: fff_print_tests
5/7 Test #5: fff_print_tests .................. Passed 33.44 sec
Start 6: sla_print_tests
6/7 Test #6: sla_print_tests .................. Passed 33.50 sec
Start 7: slic3rutils_tests
7/7 Test #7: slic3rutils_tests ................ Passed 3.30 sec
100% tests passed, 0 tests failed out of 7
Total Test time (real) = 135.16 sec