[BUGFIX] Ensure unique names when labeling objects #14431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using firmware specific object labeling the object names generated are not unique. To reproduce add multiple shapes to the build plate and export the g-code. This will result in exclude object definitions like this: ``` EXCLUDE_OBJECT_DEFINE NAME='Shape_Box' ... EXCLUDE_OBJECT_DEFINE NAME='Shape_Box' ... EXCLUDE_OBJECT_DEFINE NAME='Shape_Box' ... ... ``` With this patch the naming scheme has been changed: - The object ID is only increased when a new object is being processed - The object ID is always appended to the base name of the object - The instance ID is appended to objects with multiple instances. This results in the following names: ``` EXCLUDE_OBJECT_DEFINE NAME='Shape_Box_1' EXCLUDE_OBJECT_DEFINE NAME='Shape_Box_2' EXCLUDE_OBJECT_DEFINE NAME='Shape_Box_3' EXCLUDE_OBJECT_DEFINE NAME='Shape_Box_4' EXCLUDE_OBJECT_DEFINE NAME='Shape_Box_5_(Instance_1)' EXCLUDE_OBJECT_DEFINE NAME='Shape_Box_5_(Instance_2)' EXCLUDE_OBJECT_DEFINE NAME='Shape_Box_5_(Instance_3)' EXCLUDE_OBJECT_DEFINE NAME='Shape_Box_5_(Instance_4)' EXCLUDE_OBJECT_DEFINE NAME='Shape_Box_6' ``` This has been reported in prusa3d#13308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using firmware specific object labeling the object names generated are not unique. To reproduce add multiple shapes to the build plate and export the g-code.
This will result in exclude object definitions like this:
With this patch the naming scheme has been changed:
This results in the following names:
This has been reported in #13308