When importing a STEP file, we would delete text in the filename after the last dot and not after the first dot. #14952
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with the naming of imported stl file, it should be better to remove the extension deletion when importing step file. We keep dots in name of object when import and in projects name when saving to .3mf.
rongith
force-pushed
the
rongith-change_dot_trunc_STEP_import
branch
from
1660b43 to
3be1829
Compare
Contributor
Author
|
This is the behavior after the latest commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a STEP file, we would delete text in the filename after the last dot and not after the first dot.
Fixes #8954
Before:
After: