Reduce warnings stemming from libslic3r/Config.hpp
#15106
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbuzdalov
changed the title
using for some virtual methods in libslic3r/Config.hpplibslic3r/Config.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some build environments, such as Gentoo,
-Woverloaded-virtualis enabled by default, which produces an immense amount of warnings (X was hidden by Y) when compiling PrusaSlicer. Most of them come fromlibslic3r/Config.hpp, and here from two methods:serialize, which are two different things (the main virtualstd::string serialize(), and the private template method apparently used by cereal)operator ==, for which there is a base config virtual method and a plenty of non-virtual specific overloads.This PR eliminates most if not all of these warnings by introducing
usingdirectives where necessary. To the best of my understanding, this changes exactly nothing in the binaries and should be safe.