-
Notifications
You must be signed in to change notification settings - Fork 346
Updated VMC groups #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated VMC groups #1594
Conversation
|
Apparently the comment I added is causing one of the checks to fail. Whoever reviews this can go ahead and remove it if need be. |
|
Can we not use this opportunity to also correct this game? Grandia III | SCAJ-20141, SLPM-65976, SLPM-85976, SLUS-21334, SLUS-21345 | XEBP_000.10 [ISSUE]: add missing VMC group for Grandia 3 #1585 |
There appears to be a missing space between the code and the comment on line 1403 Open-PS2-Loader/src/vmc_groups.c Line 1403 in 2b11590
|
|
Hello @AcidReach Have you checked if the problem has been resolved? |
|
@MinZe25 do you know how to add a second game / disc to an existing VMC? |
It should work without any difference 🤔 |
That’s what I thought. I’m literally 100 miles from my home at the moment. When I get back I’ll try deleting the vmc for Grandia 3 and then try re-creating it and linking it to both disc 1 and 2 and report back. |
|
Me neither, it worked with other grouped disc's too
|
|
unfortunately it still didn’t work. the vmc creates successfully for disc 1 but then won’t add to disc 2. it just says that the vmc already exists. this behaviour doesn’t happen with other vmc groups when adding to multiple discs. |
|
This basically returns the string name of the vmc at the moment of the prompt. The detection of the existing vmc (in theory) wasn't changed with my pr (nor this one). Maybe it's a bug regarding multidisks? Can you try to manually create a random vmc to the first disc and then try to assign it to the second one? |
|
Do you happen to have a VMC for this game-id already? If so can you remove it? |

Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Updated vmc_groups.c to reflect recent changes made to the VMC group page on the neutrino launcher wiki.