Skip to content

Conversation

@sync-on-luma
Copy link
Contributor

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

Updated vmc_groups.c to reflect recent changes made to the VMC group page on the neutrino launcher wiki.

@sync-on-luma
Copy link
Contributor Author

Apparently the comment I added is causing one of the checks to fail. Whoever reviews this can go ahead and remove it if need be.

@AcidReach
Copy link

Can we not use this opportunity to also correct this game?

Grandia III | SCAJ-20141, SLPM-65976, SLPM-85976, SLUS-21334, SLUS-21345 | XEBP_000.10

[ISSUE]: add missing VMC group for Grandia 3 #1585

@Jaajees
Copy link
Contributor

Jaajees commented Oct 23, 2025

Apparently the comment I added is causing one of the checks to fail. Whoever reviews this can go ahead and remove it if need be.

There appears to be a missing space between the code and the comment on line 1403

{"XEBP_000.01", titles_XEBP_000_01, count_XEBP_000_01},//Group 76

@rickgaiser
Copy link
Member

Can we not use this opportunity to also correct this game?

Grandia III | SCAJ-20141, SLPM-65976, SLPM-85976, SLUS-21334, SLUS-21345 | XEBP_000.10

[ISSUE]: add missing VMC group for Grandia 3 #1585

Will be fixed in #1596

Change LGTM. Merging.

@rickgaiser rickgaiser merged commit e53edb2 into ps2homebrew:master Oct 23, 2025
16 of 17 checks passed
@Jaajees
Copy link
Contributor

Jaajees commented Oct 25, 2025

Hello @AcidReach

Have you checked if the problem has been resolved?

@AcidReach
Copy link

AcidReach commented Oct 26, 2025

i’m trying to add it to disc 2 but it’s saying that the memory card already exists and it won’t add it to disc 2.

IMG_0242

@rickgaiser
Copy link
Member

@MinZe25 do you know how to add a second game / disc to an existing VMC?

@MinZe25
Copy link
Contributor

MinZe25 commented Oct 27, 2025

@MinZe25 do you know how to add a second game / disc to an existing VMC?

It should work without any difference 🤔

@AcidReach
Copy link

AcidReach commented Oct 27, 2025

@MinZe25 do you know how to add a second game / disc to an existing VMC?

It should work without any difference 🤔

That’s what I thought. I’m literally 100 miles from my home at the moment. When I get back I’ll try deleting the vmc for Grandia 3 and then try re-creating it and linking it to both disc 1 and 2 and report back.
I didn’t get this behaviour with any other vmc grouped discs though.

@MinZe25
Copy link
Contributor

MinZe25 commented Oct 27, 2025

Me neither, it worked with other grouped disc's too

@MinZe25 do you know how to add a second game / disc to an existing VMC?

It should work without any difference 🤔

That’s what I thought. I’m literally 100 miles from my home at the moment. When I get back I’ll try deleting the vmc for Grandia 3 and then try reverting it and linking it to both disc 1 and 2 and report back.
I didn’t get this behaviour with any other vmc grouped discs though.

@AcidReach
Copy link

unfortunately it still didn’t work. the vmc creates successfully for disc 1 but then won’t add to disc 2. it just says that the vmc already exists. this behaviour doesn’t happen with other vmc groups when adding to multiple discs.

@MinZe25
Copy link
Contributor

MinZe25 commented Oct 30, 2025

This basically returns the string name of the vmc at the moment of the prompt. The detection of the existing vmc (in theory) wasn't changed with my pr (nor this one). Maybe it's a bug regarding multidisks?

Can you try to manually create a random vmc to the first disc and then try to assign it to the second one?

@rickgaiser
Copy link
Member

Do you happen to have a VMC for this game-id already? If so can you remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants