Add ability to load cover art from tar archive for BDM/HDD devices #1632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
A hard-coded tar archive file called
art.tarcan be placed into theARTdirectory (flattened images) to be loaded as cover art.This PR introduces a way to avoid parsing through the many files on large populated devices and gives the user an option to load them from a single archive instead.
Currently only BDM is tested, HDD (untested). There could be improvements in the timing of when the tar file entries are loaded into memory and even hooking the game list cache and parsing only the headers for those art files to keep the memory footprint smaller. Boot time could be improved by caching the headers on first boot.
To give an idea for how fast this can be, here is a video describing the behavior: Click Here. This is on a fully populated 6TB 5400 RPM drive with a 1.4GB tar file with the full OPLM Art Archive (only the COV,BG,LGO images).
As this is my first major contribution to an open-source project of this nature, please understand that I am learning and I wish to make this the best effort I can. If there is anything I can improve please let me know so I can do so. Thanks guys/gals.