Repository navigation
Drop PHP 8.1, and require a Psalm 7 release that doesn't suggest purity annotations by default - #167
Merged
Merged
Conversation
…ty annotations by default On PHP 8.1 Composer can only install Psalm 7.0.0-rc18 and older, which ask the test's helpers to be marked pure; the lowest dependencies installed rc3. The ORM query helper of the taint test goes back to a plain function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The taint test's ORM query helper carried an
@psalm-suppress InvalidReturnType, only because on PHP 8.1 (Psalm 7.0.0-rc18 at most) and with the lowest dependencies (rc3) Psalm asks for it to be marked pure.Before
After
PHP 8.1 is dropped, and
vimeo/psalmstarts at 7.0.0-rc28, which made purity suggestions opt-in: the lowest dependencies now install Psalm 7.0.0.