Repository navigation
Don't make the rows the database gives taint sources - #168
Merged
Merged
Conversation
A row holds user input only if a query stored it there, which Psalm follows from the queries storing values to those reading them (vimeo/psalm#14159), not by default. The queries stay SQL sinks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every row DBAL or an ORM query gives is reported as tainted, even when no query stored user input in it.
Before
After
The queries stay SQL sinks. What a query stores flowing to the queries reading it will come from vimeo/psalm#14159's
@psalm-database-*annotations, once a Psalm release has them.