Repository navigation
Highlight non-default settings while hovering Reset - #158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In the playground's Settings drawer, a setting that differs from its default is marked only with a trailing
*, and the Settings button only shows a count ("Settings · 2 changed"). In a long drawer the asterisks are easy to miss, so before clicking Reset you can't quickly see which settings it will restore.Refs #0
Solution
Hovering or keyboard-focusing Reset now highlights every setting that differs from its default, in the same yellow the editor uses for highlighted lines. It's CSS only:
updateSettingsSummary()already puts a.changedclass on those rows, and a:has()selector on the drawer reacts to the button's hover/focus state. Browsers without:has()show no highlight; nothing else changes.