Repository navigation
Link project pages to GitHub with an icon and drop the README snippet - #59
Merged
Merged
Conversation
The project name was itself a link to GitHub, which read as a link to the Shepherd page. It is now plain text, and a GitHub mark next to it opens the repository. The Add to README block goes away, and so does copy.js on this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
On a project page the name (e.g.
vimeo/psalm) is itself a link to GitHub, so clicking the page title unexpectedly leaves Shepherd. The page also has an "Add to README" block with the badge Markdown, which is clutter now that the badges sit right above it.Solution
The project name is plain text. Next to it, a GitHub mark (the Primer
mark-githubocticon, inline SVG) links to the repository. It hasaria-label="<owner/repo> on GitHub"and a "Open on GitHub" tooltip. The empty "no reports yet" page shows the same title.The "Add to README" block is removed, along with its CSS (
.readme-details,.snippet*) andcopy.json this page. The home page still loadscopy.jsfor the install commands.