Repository navigation
Keep the home share card readable when previews crop it - #63
Merged
Merged
Conversation
Previews that centre-crop og:image to a square cut the left-aligned headline to "tch your PHP get / cter.". The content now sits in a centred 540px column that survives a 630x630 crop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Some link previews crop
og:imageto a square or near-square around its centre. The home card had a left-aligned headline that ran almost the full 1200px width, so those previews showed "tch your PHP get / cter." and the start of the command.Solution
og.pngkeeps the same size, colours, fonts and content, but everything is now centred in a 540px column: the sheep logo with "Shepherd" and the "by Psalm" pill, "Watch your PHP / get stricter." on two lines, and thevendor/bin/psalm --shepherdcommand. A 630×630 centre crop keeps the whole card with about 45px to spare on each side. A faint dot grid near the edges keeps the full-width card from looking empty.The image URL already carries
?v=<mtime>, so previews pick up the new file without other changes.