feat(#495): add foreign lpvm sizeof instr#529
Merged
pschachte merged 5 commits intopschachte:masterfrom Jan 29, 2026
Merged
Conversation
jimbxb
force-pushed
the
feat/sizeof
branch
4 times, most recently
from
a27045a to
19adaa0
Compare
pschachte
requested changes
Dec 15, 2025
Owner
pschachte
left a comment
pschachte
left a comment
There was a problem hiding this comment.
Just needs a bit more doc; otherwise, it looks great. I love the improvement to machine_word.wybe.
Owner
|
Is this obsolete now? The PR I just merged included the sizeof primitive. |
Collaborator
Author
|
I guess it is a little redundant. Merging this PR will close the related issue automatically, which is nice. There'd also be a commit in the history of main, which is nice. |
pschachte
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #495