Conversation
JelleZijlstra
approved these changes
Feb 20, 2026
cobaltt7
pushed a commit
to cobaltt7/black
that referenced
this pull request
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
normalize_fstring_quotes, the loop that checks whether quote normalization would introduce more escaping overwritesorig_escape_countandnew_escape_counton each iteration:After the loop finishes, both variables only hold the counts from the last segment. For an f-string with multiple text segments (e.g.
f'text1{expr}text2'), a newly-introduced escape in an earlier segment is ignored entirely.This changes the loop to aggregate the counts across all segments:
Note: this function is currently only referenced in a commented-out block in
linegen.py, so there's no runtime impact today. But the fix is worth having before f-string quote normalization is enabled.