-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Allow multiple cases per fixture file #5149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pedro-Muller29
wants to merge
9
commits into
psf:main
Choose a base branch
from
Pedro-Muller29:feat/4506-multi-cell-fixtures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
aa085ef
Add multi-cell fixture format to the test loader
Pedro-Muller29 a38f018
Migrate preview_long_strings__regression to multi-cell format
Pedro-Muller29 b4c95b1
Migrate preview_long_strings to multi-cell format
Pedro-Muller29 004ffb5
Add unit tests for the multi-cell fixture loader
Pedro-Muller29 536830e
Add changelog entry for multi-cell fixture format (#5147)
Pedro-Muller29 e6fdab0
Allow a top-level `# flags:` in multi-cell fixtures
Pedro-Muller29 a38fd6a
Update PR number in changelog
Pedro-Muller29 bd062f3
Apply self-format
Pedro-Muller29 71af7a3
Update CHANGES.md
Pedro-Muller29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this to
[output]? The magical comment is a bit confusing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no, with the idea being that any of these smaller case cells has the same format as a pre-change test file, so they can share the same parsing/mental machinery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy's format (which this borrows from) uses a bracket marker for this (
[out]). Should I move the multi-cell format the same way ([case ]+[output]) and leave single-case files on# output?