Report parse errors as file:line:column#5237
Open
wanxiankai wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3157.
Parser failures currently reach the CLI as a string, so the report prefix separates the file path from the line and column (
cannot format path: Cannot parse: line:column). This prevents editors and problem matchers from recognizing a standard source location.This change keeps structured context, line, column, and diagnostic details on
InvalidInputwhile preserving its existing string representation for API consumers such as blackd. CLI reports now render parser failures aserror: cannot parse: path:line:column, while non-parser failures retain the existingcannot formatoutput. The structured attributes are also covered by a pickle round trip because multi-file formatting passes exceptions back from worker processes.Checklist - did you ...
--previewstyle, following the stability policy? (No code style change.)CHANGES.mdif necessary?Test results
471 passed, 3 skipped, 8 subtests passed