Fix unstable formatting with comments on optional parens#5241
Open
l46983284-cpu wants to merge 2 commits into
Open
Fix unstable formatting with comments on optional parens#5241l46983284-cpu wants to merge 2 commits into
l46983284-cpu wants to merge 2 commits into
Conversation
l46983284-cpu
force-pushed
the
fix-3701-unstable-multi-pass-comment
branch
from
July 17, 2026 11:41
5ffc355 to
3535e22
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes multi-pass instability when an inline comment sits on optional parentheses (assert message / assignment RHS). Omitting those parens re-parented the comment onto a different leaf, so the RHS splitter chose a different shape on the next pass and tripped the second-pass stability check.
can_omit_invisible_parensnow returns false when the optional opening paren already carries an inline comment, which pins the comment and keeps the formatting stable. Covers the #3701 reproducer and the same class from #3706 / #4384.Checklist - did you ...
--previewstyle, following thestability policy?
(N/A — this is an unstable-formatting bug fix, not a deliberate style change.)
CHANGES.mdif necessary?(N/A — unintended formatting bug; no style-guide rewrite.)
Fixes #3701