Remove venv usage when installing psp-pacman#36
Closed
diamant3 wants to merge 1 commit intopspdev:masterfrom
Closed
Remove venv usage when installing psp-pacman#36diamant3 wants to merge 1 commit intopspdev:masterfrom
diamant3 wants to merge 1 commit intopspdev:masterfrom
Conversation
Member
|
I think the reason for using pip was that Debian Buster had a version of meson that was too old to build Pacman. It also lowered the dependencies. You would need to make sure that the website is updated too, as well as the automated builds. |
Member
|
Just so you know, this change would affect the following repos:
|
Member
Author
|
Thanks Wouter. That's true, I'll just close this PR and create a new one that should properly handle instead of total removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to propose this PR to totally remove the usage of virtual environment of pacman installation. I think there's no potential issue with their installed packages and nowadays the installation of python's packages are via package manager instead of pip.