-
Notifications
You must be signed in to change notification settings - Fork 115
Jira issues with worklogs #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will add a config option to include or exclude the time spent for each worklog entry. |
14be180 to
b99fb55
Compare
Done. |
|
If I understand correctly, the tests fail due to github exceeding its rate limit. |
I reran the tests and they pass now, so I guess I was correct. |
|
@sandrobonazzola @lukaszachy @psss @optak: Do you think you can review this PR? |
4c164d9 to
f6a0fea
Compare
|
Overall looks good to me, a few comments:
|
|
@sandrobonazzola , thank you for the review.
I sure can. Would mocked tests be okay?
No I have my own work that uses worklogs but I don't know of anybody else in my team that uses this so far. We're only downloading worklogs for issues that were found when a worklog entry matches the author and timing constraints. For the other Jira issues that we find, we don't download worklogs. The performance should only be impacted by the new query and I don't have a database to test that against. Should this niche and maybe less known worklog feature become a problem we can maybe think about having the |
|
@sandrobonazzola I've introduced an option called |
1ed0801 to
0a33d83
Compare
|
@sandrobonazzola can you please give this another review? |
0a33d83 to
3b835f7
Compare
sandrobonazzola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
|
@sandrobonazzola I've addressed the changes that you requested. Thank you for working on this. I just wanted to say that I have pre-commit installed and running locally but I don't know why it fails in this PR. |
@sandrobonazzola I've opened an issue (#439) for this problem because it seems unrelated to my PR here. |
This finds Jira issues and their worklogs. This adds the `-worklog` option to the stats, next to `-commented`, `-resolved`, etc. You can set `worklog_show_time_spent=on|off` in your Jira config. Fixes psss#428
4ce9770 to
e442fb4
Compare
|
@sandrobonazzola I've rebased onto |
sandrobonazzola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This finds Jira issues and their worklogs.
This adds the
-worklogoption to the stats, next to-commented,-resolved, etc.To make this feature available you need to set
worklog_enable=on. Maybe this will become the default in the future but for now it isoffby default.You can set
worklog_show_time_spent=on|offin your Jira config to adjust if you want to include the time that was spent on each work log (i.e. see(33m)in the first work log).Fixes #428
Here is some example output:
Here's an example workflow of entering two worklogs (using jira-worklogger and then printing them using
did today --jira-worklog. (Wait for the very end to see what this PR outputs.)