Add type hints to Confluence plugin #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sandrobonazzola
commented
Nov 18, 2025
sandrobonazzola
commented
- Add comprehensive type hints throughout the Confluence plugin
- Refactor class hierarchy:
- Rename ConfluenceStats to ConfluenceStatsGroup (main stats group)
- Introduce ConfluenceStats as abstract base class for stat classes
- Update PageCreated, PageModified, CommentAdded to inherit from ConfluenceStats
- Improve error handling:
- Add session renewal on 401 (unauthorized) responses
- Add retry logic for connection aborted errors
- Add renew_session() method for session management
- Add markdown format support for ConfluenceComment output
- Fix missing docstring for CommentAdded class
- Update test file to use ConfluenceStatsGroup and add type hints
- Fix typo in test function name (invaliad -> invalid)
- Change TIMEOUT constant to float (60.0) for type consistency
sandrobonazzola
force-pushed
the
confluence_types
branch
from
559419f to
c1f1134
Compare
- Add comprehensive type hints throughout the Confluence plugin - Refactor class hierarchy: * Rename ConfluenceStats to ConfluenceStatsGroup (main stats group) * Introduce ConfluenceStats as abstract base class for stat classes * Update PageCreated, PageModified, CommentAdded to inherit from ConfluenceStats - Improve error handling: * Add session renewal on 401 (unauthorized) responses * Add retry logic for connection aborted errors * Add renew_session() method for session management - Add markdown format support for ConfluenceComment output - Fix missing docstring for CommentAdded class - Update test file to use ConfluenceStatsGroup and add type hints - Fix typo in test function name (invaliad -> invalid) - Change TIMEOUT constant to float (60.0) for type consistency Signed-off-by: Sandro Bonazzola <[email protected]>
sandrobonazzola
force-pushed
the
confluence_types
branch
from
c1f1134 to
c767454
Compare
Collaborator
|
How come this was merged without a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.