Add type hints to items plugin #443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sandrobonazzola
commented
Nov 20, 2025
sandrobonazzola
commented
- Add return type annotations to header() and fetch() methods
- Add type hints to CustomStats.init parameters
- Import User type from did.base
- Fix test assertion to properly call header() method
- Add return type annotations to header() and fetch() methods - Add type hints to CustomStats.__init__ parameters - Import User type from did.base - Fix test assertion to properly call header() method Signed-off-by: Sandro Bonazzola <[email protected]>
kwk
reviewed
Nov 21, 2025
| assert stats.stats[0].name == "Work on tasks" | ||
| assert stats.stats[0].stats == ['Task One', 'Task Two', 'Task Three'] | ||
| assert stats.header() is None | ||
| stats.header() |
Collaborator
Author
There was a problem hiding this comment.
header doesn't return. So either we needed to change header() to return None or the assert here was not complying with typing. No personal preference, kept the call to header just for coverage sake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.