Skip to content
This repository was archived by the owner on Apr 14, 2024. It is now read-only.
This repository was archived by the owner on Apr 14, 2024. It is now read-only.

Support pattern payload of size 0 #366

Description

@pstavirs

The pattern payload protocol framesize is variable and is calculated based on the frameLength and the sum of all protocol frame sizes.

However, when building the frame value, for a calculated size of 0, pattern payload still adds one byte. This is due to this very old code in payload.cpp (not sure why it was added) -

                    // FIXME: Hack! Bad! Bad! Very Bad!!!
                    if (dataLen <= 0)
                        dataLen = 1;

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions