Skip to content

fix: propagate error on checkpoint publish during recovery #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psteinroe merged 1 commit into from
Apr 5, 2026
Merged

fix: propagate error on checkpoint publish during recovery #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,20 +220,9 @@ where
let lag_milliseconds = (Utc::now() - checkpoint_event.id.created_at).num_milliseconds();
metrics::record_processing_lag(self.config.id, lag_milliseconds);

let result = self
.sink
self.sink
.publish_events(vec![(*checkpoint_event).clone()])
.await;

if let Err(err) = result {
warn!(
checkpoint_event_id = %checkpoint_event.id.id,
current_batch_event_id = %current_batch_event_id.id,
error = %err,
"Failed to publish checkpoint event during failover recovery; skipping replay"
);
return Ok(());
}
.await?;

info!(
"Sink recovered, starting failover replay from checkpoint event id: {:?}",
Expand Down
Loading