Conversation
This change is a temporary feature in response to the ShaclORClassEditor that was introduced to shacl-vue in d1b8a8c445a394119cc4a520fccc7b8c560fdb51. The ShaclORClassEditor specifically matches propertyShapes that have sh:or and where all elements in the sh:or array have an sh:class key. This makes it simple to assume that the corresponding value would be a namedNode, which is also what getPropertyNodeKind has been updated to return. This feature is not intended to fully support any sh:or scenario, only to have parity with shacl-vue to the level that the latter supports sh:or. Future changes should consider moving the determination of a property's nodekind to shacl-vue itself, at the point where data is entered into the UI. This would prevent the necessity of having to determine the nodeKind for what could be very complicated recursive sh:or arrays with a variety of nodekinds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a temporary feature in response to the ShaclORClassEditor
that was introduced to shacl-vue in d1b8a8c445a394119cc4a520fccc7b8c560fdb51.
The ShaclORClassEditor specifically matches propertyShapes that have sh:or and
where all elements in the sh:or array have an sh:class key. This makes it simple
to assume that the corresponding value would be a namedNode, which is also what
getPropertyNodeKind has been updated to return.
This feature is not intended to fully support any sh:or scenario, only to have
parity with shacl-vue to the level that the latter supports sh:or.
Future changes should consider moving the determination of a property's nodekind
to shacl-vue itself, at the point where data is entered into the UI. This would
prevent the necessity of having to determine the nodeKind for what could be very
complicated recursive sh:or arrays with a variety of nodekinds.
Tests are also updated.
This closes #12. A new issue should be opened for supporting the full range of
sh:or