Merged
Conversation
This changes the adhoc way in which request responses were handled into a structured handling approach, where errors are thrown and caught and returned as an object with standard properties, such as 'success', 'message', 'error', 'skipped', 'url'. This holds for successful requests as well. This allows all errors to be bubbled upwards in a structured and consistent way, so that frontend apps that use this library can react to request responses in a systematic way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the adhoc way in which request responses were handled
into a structured handling approach, where errors are thrown and
caught and returned as an object with standard properties, such as
'success', 'message', 'error', 'skipped', 'url'. This holds for
successful requests as well. This allows all errors to be bubbled
upwards in a structured and consistent way, so that frontend apps
that use this library can react to request responses in a systematic
way.