Harden UDP queue metrics InfluxDB writes against overlap and failed resets#1649
Draft
Copilot wants to merge 5 commits into
Draft
Harden UDP queue metrics InfluxDB writes against overlap and failed resets#1649Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
Co-authored-by: mountaindude <1029262+mountaindude@users.noreply.github.com>
Co-authored-by: mountaindude <1029262+mountaindude@users.noreply.github.com>
Co-authored-by: mountaindude <1029262+mountaindude@users.noreply.github.com>
Co-authored-by: mountaindude <1029262+mountaindude@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on feedback from review thread
Harden UDP queue metrics InfluxDB writes against overlap and failed resets
Jun 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR addresses the review-thread feedback on the new UDP queue metrics writer. The main issue was incorrect snapshot/reset behavior when InfluxDB writes failed or overlapped, which could drop counters or start duplicate periodic writers.
Write completion semantics
postUdpQueueMetricsToInfluxDb()now supports separateonSuccessandonCompletecallbacks.Timer overlap protection
startUdpQueueMetricsTimer()now guards against duplicate initialization.Focused test coverage
onSuccessvsonCompletegetMetrics()errorsMinor log cleanup