Fix multiple bugs: TypeScript strict mode errors, PHP division by zero, null dereference, and logic issues - #5681
Open
itriedcoding wants to merge 1 commit into
Conversation
…o, null dereference, and logic issues - Fix 12 TypeScript noImplicitAny errors by adding explicit event handler types - Fix division by zero in NodeRepository when node has no resource limits set - Fix null dereference in NodeRepository getUsageStats when node has no servers by changing inner join to left join - Fix pass-by-reference variable reassignment bug in StartupModificationService where egg_id/nest_id changes were lost - Fix undefined variable in BuildModificationService - Fix duplicate 'description' entry in Node model - Fix ->failed() being called twice in ProcessScheduleService - Fix unhandled transaction rollback on exception in AssignmentService
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple bugs found through static analysis and code review across both the TypeScript frontend and PHP backend.
TypeScript Fixes (12 errors)
oImplicitAny errors in strict mode across: Checkbox, Modal, Switch, JavaVersionModalFeature, FileEditContainer, UploadButton, AllocationRow, VariableBox
PHP Fixes
High Severity:
Medium Severity:
emove_allocations is not
Low Severity: